Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of AMP pages #2284

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Better detection of AMP pages #2284

merged 4 commits into from
Jan 16, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Dec 21, 2023

Task/Issue URL: https://app.asana.com/0/1202198075905303/1202190330709645/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. See BSK PR

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Dec 21, 2023
@SlayterDev SlayterDev marked this pull request as ready for review December 21, 2023 20:41
@SlayterDev SlayterDev merged commit 7c00dcc into main Jan 16, 2024
10 checks passed
@SlayterDev SlayterDev deleted the brad/better-amp-checks branch January 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants